package.json name different from module name cause panic #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @endosama, I think the PR makes sense, thanks for the contribution 🙏 |
jfrolich
approved these changes
Jul 8, 2025
|
Let me know if you need a new version release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I started getting some issues when bumping from version
1.0.9to1.2.2.We're currently importing this package in our codebase (monorepo):
https://github.com/teamwalnut/rescript-urql
Which has a
rescript-urqlname in thepackage.jsonbut a different name@urql/rescriptin thebsconfig.jsonWhen the package is resolved, it's stored with
rescript-urqlas a key, but when resolving the dependencies in our project, we reference thebsconfig.jsonname of the module, so@urql/rescript, causing a:I can change the
package.jsonname for that project, but I'm not sure if that's the correct behaviour and we should instead rely always only on the name in thebsconfig/rescript.json🤔If needed, I can try creating a small environment with the issue or add some tests.
Let me know wdyt 🙏